Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iox-#2047 Fix gcc 13 warnings #2089

Merged
merged 6 commits into from
Nov 13, 2023
Merged

iox-#2047 Fix gcc 13 warnings #2089

merged 6 commits into from
Nov 13, 2023

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Nov 11, 2023 •
edited
Loading

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

This PR fixes the warnings in GCC 13. They are kind of false positives but I was able to give the compiler some hints to do not trigger them for some of the warnings.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido self-assigned this Nov 11, 2023
@elBoberido
Copy link
Member Author

@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff @budrus feel free to add yourself as reviewer

@elBoberido elBoberido force-pushed the iox-2047-fix-gcc-13-warnings branch from 737b199 to 992d0bd Compare November 11, 2023 18:06
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2023 •
edited
Loading

Codecov Report

Merging #2089 (11b454d) into master (443a0d8) will increase coverage by 0.01%.
Report is 27 commits behind head on master.
The diff coverage is 94.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2089      +/-   ##
==========================================
+ Coverage   80.04%   80.06%   +0.01%     
==========================================
  Files         417      417              
  Lines       16055    16066      +11     
  Branches     2255     2253       -2     
==========================================
+ Hits        12852    12864      +12     
  Misses       2398     2398              
+ Partials      805      804       -1
Flag Coverage Δ
unittests 79.85% <94.82%> (+0.02%) ⬆️
unittests_timing 15.32% <22.41%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...yx_hoofs/vocabulary/include/iox/detail/variant.inl 94.17% <100.00%> (+0.23%) ⬆️
iceoryx_hoofs/vocabulary/include/iox/variant.hpp 100.00% <ø> (ø)
...nternal/popo/building_blocks/chunk_distributor.hpp 100.00% <ø> (ø)
...nternal/popo/building_blocks/chunk_distributor.inl 95.62% <100.00%> (-0.10%) ⬇️
...ryx_posh/source/mepoo/shm_safe_unmanaged_chunk.cpp 100.00% <ø> (ø)
...ryx_hoofs/vocabulary/include/iox/detail/string.inl 96.03% <83.33%> (+0.03%) ⬆️
...clude/iceoryx_hoofs/internal/cxx/variant_queue.inl 80.00% <94.44%> (+3.17%) ⬆️

... and 1 file with indirect coverage changes

@elBoberido elBoberido force-pushed the iox-2047-fix-gcc-13-warnings branch from 992d0bd to 2bb0363 Compare November 11, 2023 18:55
@elBoberido elBoberido force-pushed the iox-2047-fix-gcc-13-warnings branch from 2bb0363 to 20e77a9 Compare November 11, 2023 19:18
@elBoberido elBoberido force-pushed the iox-2047-fix-gcc-13-warnings branch from 20e77a9 to 11b454d Compare November 12, 2023 13:33
@mossmaurice mossmaurice self-requested a review November 13, 2023 13:57
mossmaurice
mossmaurice approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/chunk_distributor.inl Show resolved Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/chunk_distributor.inl Show resolved Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/chunk_distributor.inl Show resolved Hide resolved
@elBoberido
Copy link
Member Author

@mossmaurice I guess the eclipse admins did not yet applied the changes for only one required reviewer?

@elBoberido elBoberido merged commit 90a9b03 into master Nov 13, 2023
25 checks passed
@elBoberido elBoberido deleted the iox-2047-fix-gcc-13-warnings branch November 13, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfenpiff elfenpiff elfenpiff approved these changes

@mossmaurice mossmaurice mossmaurice approved these changes

Assignees

@elBoberido elBoberido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support gcc 13.2?
3 participants
@elBoberido @mossmaurice @elfenpiff